aturoczy commented on code in PR #6539:
URL: https://github.com/apache/hive/pull/6539#discussion_r3454368382


##########
beeline/src/java/org/apache/hive/beeline/BeeLine.java:
##########
@@ -121,25 +122,6 @@
 import org.jline.terminal.Terminal;
 import org.jline.terminal.TerminalBuilder;
 
-import static org.jline.builtins.Completers.FileNameCompleter;
-
-
-/**
- * A console SQL shell with command completion.
- * <p>
- * TODO:
- * <ul>
- * <li>User-friendly connection prompts</li>
- * <li>Page results</li>
- * <li>Handle binary data (blob fields)</li>
- * <li>Implement command aliases</li>
- * <li>Stored procedure execution</li>
- * <li>Binding parameters to prepared statements</li>
- * <li>Scripting language</li>
- * <li>XA transactions</li>
- * </ul>
- *
- */

Review Comment:
   I will create follow-up JIRA tickets for these items, or at least for the 
ones that make sense to follow up on.
   For example, I am not sure what “scripting language” or “SP execution” means 
in this context. SP execution is already possible, so that part may need 
clarification before creating a separate ticket.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to