abstractdog commented on code in PR #6659:
URL: https://github.com/apache/hive/pull/6659#discussion_r3680820499
##########
llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java:
##########
@@ -158,15 +164,15 @@ public LlapTaskCommunicator(
credentialMap = new ConcurrentHashMap<>();
sourceStateTracker = new SourceStateTracker(getContext(), this);
+ ApplicationAttemptId appAttemptId = getContext().getApplicationAttemptId();
synchronized (pluginInitLock) {
- LlapTaskSchedulerService peer = LlapTaskSchedulerService.instance;
+ LlapTaskSchedulerService peer =
LlapTaskSchedulerService.pendingSchedulers.remove(appAttemptId);
if (peer != null) {
- // We are the last to initialize.
+ // We are the last to initialize for this DAG.
peer.setTaskCommunicator(this);
this.setScheduler(peer);
- LlapTaskSchedulerService.instance = null;
} else {
- instance = this;
+ pendingCommunicators.put(appAttemptId, this);
}
Review Comment:
added `TestLlapPluginRendezvous`, maybe it's an overkill, considering that
this whole patch is a single JVM multiple DAGs test scenario, and manual
testing already proved it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
