abstractdog commented on code in PR #6659:
URL: https://github.com/apache/hive/pull/6659#discussion_r3729210299
##########
llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java:
##########
@@ -158,15 +169,15 @@ public LlapTaskCommunicator(
credentialMap = new ConcurrentHashMap<>();
sourceStateTracker = new SourceStateTracker(getContext(), this);
+ this.appAttemptId = getContext().getApplicationAttemptId();
synchronized (pluginInitLock) {
- LlapTaskSchedulerService peer = LlapTaskSchedulerService.instance;
+ LlapTaskSchedulerService peer =
LlapTaskSchedulerService.pendingSchedulers.remove(appAttemptId);
Review Comment:
absolutely makes sense!
in the long term, tez might have its own solution for the same (I can also
find a ticket where this came up in tez), but now, it would be a good to move
all this hack to a separate class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]