deniskuzZ commented on code in PR #6642:
URL: https://github.com/apache/hive/pull/6642#discussion_r3764487785
##########
ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java:
##########
@@ -450,8 +454,11 @@ public static BucketMetaData parse(String bucketFileName) {
return new BucketMetaData(bucketId, 0);
}
else if(ORIGINAL_PATTERN_COPY.matcher(bucketFileName).matches()) {
- int copyNumber = Integer.parseInt(
- bucketFileName.substring(bucketFileName.lastIndexOf('_') + 1));
+ String copySuffix =
bucketFileName.substring(bucketFileName.lastIndexOf('_') + 1);
+ // Copy suffix is either a numeric counter or a 16-hex per-query
uniqueness tag.
+ // Hex-tagged files are unordered peers from concurrent writers on an
+ // non-atomic-rename FS, so there is no meaningful copy number to
assign — use 0.
+ int copyNumber = (copySuffix.length() == 16) ? 0 :
Integer.parseInt(copySuffix);
Review Comment:
maybe better
````
int copyNumber = NumberUtils.isDigits(copySuffix)
? Integer.parseInt(copySuffix)
: 0;
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
