konstantinb commented on PR #6676: URL: https://github.com/apache/hive/pull/6676#issuecomment-5346568063
@kasakrisz @zabetak @deniskuzZ @soumyakanti3578 Could one of you take a look when you have a chance? This completes the reference-time ambiguity model from HIVE-19770/HIVE-20215 (the original author and reviewer haven't contributed to the project in several years, so I'm asking the current owners of this area instead). Why you specifically: @kasakrisz and @zabetak — the marker lives in `CalcitePlanner`/RowResolver boundary handling with check sites in `TypeCheckProcFactory`/`JoinCondTypeCheckProcFactory`, and the change interacts with CTE materialization (an earlier CTAS-level check was dropped precisely because it regressed Hive-generated CTAS — context from #6423). @deniskuzZ — one of the internal-SQL fixes touches the MERGE rewrite projection in `MergeRewriter`/`MultiInsertSqlGenerator`. @soumyakanti3578 — this is the same family as HIVE-29612/HIVE-28280: shapes where CBO's RowResolver handling diverges at a query-block boundary. CI is green across all five checks, and SonarQube passed. Note that this is a backward-incompatible change (by-name references to duplicate-named columns through a subquery/CTE boundary now fail with Error 10007 under CBO); HIVE-29580 carries the incompatible-change flag accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
