konstantinb commented on code in PR #6676: URL: https://github.com/apache/hive/pull/6676#discussion_r3876117014
########## ql/src/test/results/clientpositive/llap/ambiguous_col_rejected.q.out: ########## Review Comment: The move is unfortunately not 1:1. clientnegative requires the run to abort at the first failure (`CoreNegativeCliDriver#runTest` treats a completed run as "expected to fail but didn't"), and `hive.cli.errors.ignore` — which this file needs to assert several rejections in one place — prevents exactly that abort. So clientnegative here means one file + golden per rejected shape (5 pairs today — 10 new files replacing these 2, and every future boundary shape costs another file+golden pair instead of two lines in this spec); an earlier iteration of this PR had exactly that layout and it was consolidated into this roll-up so the boundary contract reads as one spec. The mixed accept/reject-in-clientpositive pattern is established — 10 existing files use `hive.cli.errors.ignore` (`resourceplan.q` alone pins 40 FAILED lines this way) — and the mechanism-specific single-failure pins do live in clientnegative (the 9 `ambiguous_col_*.q` files there). I'd prefer keeping the roll-up for those reasons, but happy to split it into per-shape clientnegative files if you still prefer that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
