ramitg254 commented on code in PR #6703:
URL: https://github.com/apache/hive/pull/6703#discussion_r3838222001
##########
ql/src/java/org/apache/hadoop/hive/ql/plan/PTFDesc.java:
##########
@@ -226,12 +226,7 @@ public String getStreamingColumns() {
public boolean getAllEvaluatorsAreStreaming() {
VectorPTFEvaluatorBase[] evaluators =
VectorPTFDesc.getEvaluators(vectorPTFDesc, vectorPTFInfo);
- for (VectorPTFEvaluatorBase evaluator : evaluators) {
- if (!evaluator.streamsResult()) {
- return false;
- }
- }
- return true;
+ return VectorPTFDesc.getAllEvaluatorsPurelyStreaming(evaluators);
}
Review Comment:
done, kept the getAllEvaluatorsAreStreaming everywhere
##########
ql/src/test/queries/clientpositive/vector_ptf_cume_dist.q:
##########
@@ -0,0 +1,88 @@
+set hive.vectorized.testing.reducer.batch.size=2;
+
+CREATE TABLE vector_ptf_cume_dist_int(name string, rowindex int, mynumber int)
stored as orc;
Review Comment:
done, added drop statement
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
