ramitg254 commented on code in PR #6703:
URL: https://github.com/apache/hive/pull/6703#discussion_r3842954218
##########
ql/src/java/org/apache/hadoop/hive/ql/plan/VectorPTFDesc.java:
##########
@@ -468,6 +473,17 @@ public static int[]
getStreamingEvaluatorNums(VectorPTFEvaluatorBase[] evaluator
return ArrayUtils.toPrimitive(streamingEvaluatorNums.toArray(new
Integer[0]));
}
+ public static boolean getAllEvaluatorsAreStreaming(VectorPTFEvaluatorBase[]
evaluators) {
+ for (VectorPTFEvaluatorBase evaluator : evaluators) {
+ if (evaluator.isGroupAggregatedStreamingEvaluator() ||
+ evaluator.needPartitionSize() ||
Review Comment:
I think we should keep them separate:
`needPartitionSize` : solely intended for partition size (would be helpful
when adding vectorized support for percent rank).
`isGroupAggregatedStreamingEvaluator`: solely intended for group aggregation
of row count currently but can be extended to any kind of other group wise
aggregation if needed later on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
