tanishq-chugh commented on code in PR #6656:
URL: https://github.com/apache/hive/pull/6656#discussion_r3824555141
##########
llap-server/src/java/org/apache/hadoop/hive/llap/cli/status/LlapStatusServiceDriver.java:
##########
@@ -225,30 +241,35 @@ public ExitCode run(LlapStatusServiceCommandLine cl, long
watchTimeoutMs) {
if (ret != ExitCode.SUCCESS) {
return ret;
- } else if
(NO_YARN_SERVICE_INFO_STATES.contains(appStatusBuilder.getState())) {
+ }
+
+ if (NO_YARN_SERVICE_INFO_STATES.contains(appStatusBuilder.getState())) {
+ updateRunningThresholdAchieved(appStatusBuilder,
cl.getRunningNodesThreshold());
Review Comment:
is `updateRunningThresholdAchieved` call needed here? This condition should
be true only when state is Complete or Launching, but i believe in that case
`updateRunningThresholdAchieved` just returns ?
##########
llap-server/src/java/org/apache/hadoop/hive/llap/cli/status/LlapStatusServiceDriver.java:
##########
@@ -404,6 +425,11 @@ private ExitCode populateAppStatusFromServiceStatus(String
appName, ServiceClien
*/
private ExitCode populateAppStatusFromLlapRegistry(AppStatusBuilder
appStatusBuilder, long watchTimeoutMs)
throws LlapStatusCliException {
+ return populateAppStatusFromLlapRegistry(appStatusBuilder, watchTimeoutMs,
false);
+ }
Review Comment:
there is no usages of this old definition, i think it can be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
