Manya0407 commented on code in PR #6656:
URL: https://github.com/apache/hive/pull/6656#discussion_r3893344479
##########
llap-server/src/java/org/apache/hadoop/hive/llap/cli/status/LlapStatusServiceDriver.java:
##########
@@ -71,7 +71,7 @@ public class LlapStatusServiceDriver {
private static final Logger CONSOLE_LOGGER =
LoggerFactory.getLogger("LlapStatusServiceDriverConsole");
private static final EnumSet<State> NO_YARN_SERVICE_INFO_STATES = EnumSet.of(
- State.APP_NOT_FOUND, State.COMPLETE, State.LAUNCHING);
+ State.COMPLETE, State.LAUNCHING);
Review Comment:
Added an explicit early return when state is APP_NOT_FOUND on the YARN path,
so we don’t continue into YARN Service/registry calls. K8s/Docker still uses
the registry-only path via usesRegistryBasedLlapStatus() at the top of run().
##########
service/src/resources/hive-webapps/static/js/json.human.js:
##########
@@ -138,7 +138,9 @@
var boolOpt = options.bool;
container = document.createElement('div');
- if (boolOpt.showImage) {
+ if (boolOpt.showImage && boolOpt.img && boolOpt.img.true &&
boolOpt.img.false
+ && ('' + boolOpt.img.true).startsWith('/static/')
+ && ('' + boolOpt.img.false).startsWith('/static/')) {
Review Comment:
Replaced .startsWith('/static/') with .indexOf('/static/') === 0 in both
places for IE11 compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
