Aggarwal-Raghav commented on code in PR #6733:
URL: https://github.com/apache/hive/pull/6733#discussion_r3878351121
##########
llap-client/src/test/org/apache/hadoop/hive/llap/TestAsyncPbRpcProxy.java:
##########
@@ -32,13 +32,30 @@
import org.apache.commons.lang3.mutable.MutableInt;
import org.apache.hadoop.hive.llap.LlapNodeId;
import org.apache.hadoop.hive.llap.tez.LlapProtocolClientProxy;
-import org.junit.Assert;
-import org.junit.Test;
-
-public class TestAsyncPbRpcProxy {
+import org.junit.jupiter.api.BeforeAll;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.Timeout;
+
+class TestAsyncPbRpcProxy {
+
+ /**
+ * Front-loads one-time initialization (Mockito mock generation,
classloading, log4j2
+ * setup) so the per-test timeouts guard only the code under test. A timeout
here
+ * indicates a starved executor, not a test bug (HIVE-26089).
+ */
+ @BeforeAll
+ @Timeout(value = 60, threadMode = Timeout.ThreadMode.SEPARATE_THREAD)
+ static void warmUp() {
+ mock(Message.class);
+ mock(LlapProtocolClientProxy.ExecuteRequestCallback.class);
+
org.slf4j.LoggerFactory.getLogger(TestAsyncPbRpcProxy.class).info("warm-up");
Review Comment:
Maybe use import instead of fully pacakge classification? Also, Logger can
be defined as class attibute i.e.
```
private static final Logger LOG =
LoggerFactory.getLogger(TestAsyncPbRpcProxy.class);
```
##########
llap-client/src/test/org/apache/hadoop/hive/llap/TestAsyncPbRpcProxy.java:
##########
@@ -32,13 +32,30 @@
import org.apache.commons.lang3.mutable.MutableInt;
import org.apache.hadoop.hive.llap.LlapNodeId;
Review Comment:
nit: Unused import
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
