abstractdog commented on PR #4492: URL: https://github.com/apache/hive/pull/4492#issuecomment-5507921470
> > thanks @houzhizhen for this fix so far, let me ask for some clarification: "produce incorrect result" usually means an actual query result correctness problem, is it also the case here? (or is it just about that `hasOuterJoin` returns a wrong value? I can only see plan differences, but no proof for a correctness problem, can I have some clarification here? this could also answer the question "Why are the changes needed?" better than just "this method returns a wrong value" > > @abstractdog it's not correctness, but planning issue. [ConvertJoinMapJoin#hasOuterJoin produce incorrect result](https://github.com/apache/hive/pull/4492#top) leading to join miss-classification okay, sorry for nitpicking, let me ask just not using "produce incorrect result" in the commit message and jira when this arrives on master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
