deniskuzZ commented on PR #4492: URL: https://github.com/apache/hive/pull/4492#issuecomment-5652729740
> By looking at the `hasOuterJoin` method in isolation it certainly looks like a bug. But I am not sure what fixing it entails. In various cases fixing something breaks something else so it would be nice if we had some more motivation behind this change. @zabetak I don’t think keeping an obvious bug in the code is a good approach simply because something else may currently compensate for it. That makes the code harder to reason about and leaves us relying on accidental behavior elsewhere. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
