ramitg254 commented on code in PR #6666:
URL: https://github.com/apache/hive/pull/6666#discussion_r4024718732
##########
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:
##########
@@ -3649,10 +3649,10 @@ public static enum ConfVars {
"Deprecated, use HIVE_CODAHALE_METRICS_REPORTER_CLASSES instead. This
configuration will be"
+ " overridden by HIVE_CODAHALE_METRICS_REPORTER_CLASSES if
present. " +
"Comma separated list of JMX, CONSOLE, JSON_FILE, HADOOP2"),
- HIVE_METRICS_JSON_FILE_LOCATION("hive.service.metrics.file.location",
"/tmp/report.json",
+ HIVE_METRICS_JSON_FILE_LOCATION("hive.service.metrics.file.location",
"/tmp/hs2-report.json",
"For metric class
org.apache.hadoop.hive.common.metrics.metrics2.CodahaleMetrics JSON_FILE
reporter, the location of local JSON metrics file. " +
"This file will get overwritten at every interval."),
- HIVE_METRICS_JSON_FILE_INTERVAL("hive.service.metrics.file.frequency",
"5000ms",
+ HIVE_METRICS_JSON_FILE_INTERVAL("hive.service.metrics.file.frequency",
"60000ms",
Review Comment:
is it not required for hs2 metrics separately?, I didn't saw any occurence
of it other than `TestMetricsQueryLifeTimeHook.java`
whereas `METRICS_JSON_FILE_INTERVAL` which is in metastore conf and treats
the above one as it's alias is used everywhere
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
