ramitg254 commented on code in PR #6666:
URL: https://github.com/apache/hive/pull/6666#discussion_r4025749696
##########
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:
##########
@@ -3649,10 +3649,10 @@ public static enum ConfVars {
"Deprecated, use HIVE_CODAHALE_METRICS_REPORTER_CLASSES instead. This
configuration will be"
+ " overridden by HIVE_CODAHALE_METRICS_REPORTER_CLASSES if
present. " +
"Comma separated list of JMX, CONSOLE, JSON_FILE, HADOOP2"),
- HIVE_METRICS_JSON_FILE_LOCATION("hive.service.metrics.file.location",
"/tmp/report.json",
+ HIVE_METRICS_JSON_FILE_LOCATION("hive.service.metrics.file.location",
"/tmp/hs2-report.json",
"For metric class
org.apache.hadoop.hive.common.metrics.metrics2.CodahaleMetrics JSON_FILE
reporter, the location of local JSON metrics file. " +
"This file will get overwritten at every interval."),
- HIVE_METRICS_JSON_FILE_INTERVAL("hive.service.metrics.file.frequency",
"5000ms",
+ HIVE_METRICS_JSON_FILE_INTERVAL("hive.service.metrics.file.frequency",
"60000ms",
Review Comment:
understood your point, this will work fine for separate configuration
scenario
my concern is in case of shared config ( common hive-site) for hs2 and hms
in which if a user wants to have different frequency values for hs2 and hms
assuming `hive.service.metrics.file.frequency` for hs2 and
`metastore.metrics.file.frequency` for hms then even though having different
values `metastore.metrics.file.frequency` will be picked up due to it's usage
everywhere in the code including location other than standalone metastore and
no independent usage of `hive.service.metrics.file.frequency`
I know this is the existing behaviour and you were not trying to fix this
but is it possible to replace the usage of `METRICS_JSON_FILE_INTERVAL` in
locations related to hs2 with `HIVE_METRICS_JSON_FILE_INTERVAL` so that we can
have separate values for both in case of shared config.
wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
