aturoczy commented on code in PR #6793:
URL: https://github.com/apache/hive/pull/6793#discussion_r4027531809


##########
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:
##########
@@ -4958,6 +4958,9 @@ public static enum ConfVars {
     LLAP_IO_ENCODE_ENABLED("hive.llap.io.encode.enabled", true,
         "Whether LLAP should try to re-encode and cache data for non-ORC 
formats. This is used\n" +
         "on LLAP Server side to determine if the infrastructure for that is 
initialized."),
+    LLAP_IO_PARQUET_NATIVE_ENABLED("hive.llap.io.parquet.native.enabled", 
false,

Review Comment:
   Wouldn't be this enabled by default?



##########
llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapRecordReader.java:
##########
@@ -350,6 +353,11 @@ public void start() {
 
   private boolean checkOrcSchemaEvolution() {
     SchemaEvolution evolution = rp.getSchemaEvolution();
+    if (evolution == null) {
+      // No ORC-style schema evolution to validate (e.g. native parquet path);

Review Comment:
   no orc-style?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to