abstractdog commented on code in PR #6793:
URL: https://github.com/apache/hive/pull/6793#discussion_r4044637203
##########
llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapRecordReader.java:
##########
@@ -350,6 +353,11 @@ public void start() {
private boolean checkOrcSchemaEvolution() {
SchemaEvolution evolution = rp.getSchemaEvolution();
+ if (evolution == null) {
+ // No ORC-style schema evolution to validate (e.g. native parquet path);
Review Comment:
you might be looking at an old commit, the current state of PR already has
an improved comment:
https://github.com/apache/hive/pull/6793/changes#diff-f00087a16c2c9fed9e0899d7a3718edad0215e33cc41fdd38895945ba45f2517R357-R361
```
// Only the ORC pipeline hangs an ORC SchemaEvolution off the
ReadPipeline; other formats
// (native Parquet today) handle column resolution themselves, so
there is nothing to
// validate here.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
