Manya0407 commented on PR #6746: URL: https://github.com/apache/hive/pull/6746#issuecomment-5812549775
> Hey team, it seems that there have been 10 CI runs and none of them was green! With a very naive check of the failures it seems that the changes here cause instability/flakiness. I am not at ease merging it as is unless someone clarifies that failures are unrelated. > > On a side note, CI runs cost money and resources so try to be mindful of their usage trying to keep the number of reruns low to the extend possible Hey @zabetak @thomasrebele Thanks for the heads-up The repeated reds are mostly expected golden churn, not flaky logic: this PR changes CBO selectivity and predicate ordering, so join/EXPLAIN output shifted and ~200+ .q.out files needed updates. I’ve been fixing those batch-by-batch as precommit reported them. I just pushed the last golden batch; that run is in progress and should cover the failures we were still seeing. Some failures look unrelated — e.g. Gravitino REST (localhost:… failed to respond on iceberg_rest_catalog_gravitino.q), which is Testcontainers/infra, not CBO. In the meantime, the feature/code diff is ready for review if that’s useful. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
