Manya0407 commented on PR #6746: URL: https://github.com/apache/hive/pull/6746#issuecomment-5827183329
> I don't understand why its necessary to update the golden files multiple times. The first CI run should have all the golden files that need to be updated. If the results change every time you push a new commit then it probably means that there is some sort of flakiness involved. @zabetak Precommit is green now. Sorry for the extra CI churn — I’ll consolidate goldens more aggressively next time. Actually the branch wasn’t only split-by-split golden fixes: there were several review-driven planner updates , each of which legitimately moved CBO/EXPLAIN output and needed another .q.out pass. Also,the rest was remaining qtest failures each full precommit run reported until everything matched — not nondeterministic output on the same commit. Aplogises if I wasn’t clear earlier and the extra CI runs along the way. Could you take another look when you have time? cc @rubenada @thomasrebele Thanks ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
