Copilot commented on code in PR #6656:
URL: https://github.com/apache/hive/pull/6656#discussion_r4121880273
##########
service/src/resources/hive-webapps/static/js/llap.js:
##########
@@ -32,11 +32,7 @@ window.options = {
true : "true",
false : "false"
},
- showImage : true,
- img : {
- true : 'css/true.png',
- false : 'css/false.png'
- }
+ showImage : false
Review Comment:
The PR description says `llap.html` adds cache-buster query parameters, but
that file still loads `/static/js/json.human.js` and `/static/js/llap.js`
without any version query parameters. Because the UI behavior fix can be hidden
by a cached copy of the old JavaScript, either add the cache busting change or
remove it from the PR description; otherwise existing browsers may continue
showing the broken icons after deployment.
##########
llap-server/src/java/org/apache/hadoop/hive/llap/cli/status/LlapStatusServiceDriver.java:
##########
@@ -427,7 +451,20 @@ private ExitCode
populateAppStatusFromLlapRegistry(AppStatusBuilder appStatusBui
appStatusBuilder.setLiveInstances(0);
appStatusBuilder.setState(State.LAUNCHING);
appStatusBuilder.clearRunningLlapInstances();
- return ExitCode.SUCCESS;
+ } else if (registryOnly) {
+ List<LlapInstance> registryInstances = new LinkedList<>();
+ for (LlapServiceInstance serviceInstance : serviceInstances) {
+ registryInstances.add(createLlapInstanceFromRegistry(serviceInstance));
+ }
+ if (appStatusBuilder.getAmInfo() == null) {
+ appStatusBuilder.setAmInfo(new AmInfo().setAppName(appName));
+ }
+
appStatusBuilder.clearAndAddPreviouslyKnownRunningInstances(registryInstances);
+ appStatusBuilder.setLiveInstances(registryInstances.size());
Review Comment:
When `hive.llap.daemon.service.hosts` is a fixed host list,
`LlapRegistryService` uses `LlapFixedRegistryImpl`, whose `getInstances`
returns one instance for every configured host without checking whether a
daemon is alive. This branch treats all of those entries as live and exposes
their URLs, so fixed-host deployments report healthy/running daemons even when
they are stopped or unreachable. Do not use the fixed registry entries as
liveness evidence for this status response, or add an explicit health
check/distinction for this mode.
This issue also appears on line 464 of the same file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
