Manya0407 commented on code in PR #6656:
URL: https://github.com/apache/hive/pull/6656#discussion_r4132520368
##########
llap-server/src/java/org/apache/hadoop/hive/llap/cli/status/LlapStatusServiceDriver.java:
##########
@@ -427,7 +451,20 @@ private ExitCode
populateAppStatusFromLlapRegistry(AppStatusBuilder appStatusBui
appStatusBuilder.setLiveInstances(0);
appStatusBuilder.setState(State.LAUNCHING);
appStatusBuilder.clearRunningLlapInstances();
- return ExitCode.SUCCESS;
+ } else if (registryOnly) {
+ List<LlapInstance> registryInstances = new LinkedList<>();
+ for (LlapServiceInstance serviceInstance : serviceInstances) {
+ registryInstances.add(createLlapInstanceFromRegistry(serviceInstance));
+ }
+ if (appStatusBuilder.getAmInfo() == null) {
+ appStatusBuilder.setAmInfo(new AmInfo().setAppName(appName));
+ }
+
appStatusBuilder.clearAndAddPreviouslyKnownRunningInstances(registryInstances);
+ appStatusBuilder.setLiveInstances(registryInstances.size());
Review Comment:
Addressed via explicit health checks for fixed registry mode
(!llapRegistry.isDynamic()): we GET each instance’s statusUrl (/status, 3s
timeout) and only include responsive daemons in runningInstances and
liveInstances. desiredInstances remains the configured count;
launchingInstances is set to configured − live. ZK / @… registry still uses
registered instances without these probes.
Tests: TestLlapStatusRegistryFallback (including isLlapDaemonWebResponsive);
manual Docker fixed-host validation (2/1/0 daemons up → RUNNING_ALL /
RUNNING_PARTIAL / LAUNCHING).
Note: HS2 must use the same hive.llap.daemon.web.port as daemons so status
URLs are correct (same as fixed-registry discovery elsewhere).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
