Aggarwal-Raghav commented on code in PR #6856:
URL: https://github.com/apache/hive/pull/6856#discussion_r4241329803
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/writer/HiveIcebergCopyOnWriteRecordWriter.java:
##########
@@ -55,7 +55,7 @@ class HiveIcebergCopyOnWriteRecordWriter extends
HiveIcebergDefaultWriter {
public void write(Writable row) throws IOException {
Record record = ((Container<Record>) row).get();
PositionDelete<Record> positionDelete =
IcebergAcidUtil.getPositionDelete(record, rowDataTemplate, false);
- Record rowData = positionDelete.row();
+ Record rowData = rowDataTemplate;
Review Comment:
As per javadoc of `IcebergAcidUtil.getPositionDelete()`, the
`rowDataTemplate` is modified in-place
```
Based on `rec` the method creates a position delete object, and also
populates the data filed of `rowData` with the field values from `rec`.
```
So, positionDelete.row() contains same what rowDataTemplate contains . As
`positionDelete.row()` is gone therefore, I replaced it with rowDataTemplate
Please let me know If i misunderstood your comment!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
