Aggarwal-Raghav commented on PR #6856: URL: https://github.com/apache/hive/pull/6856#issuecomment-6117881536
> > > @Aggarwal-Raghav please review sonar issues, seem related to the current changes > > > > > > @deniskuzZ , Need 1 suggestion from you on SonaType, > > > > 1. HiveCatalog.java : Its in sync (code wise not formatting wise 😅) with upstream iceberg — NIT , let me know if we want to make this small change. > > i would keep the iceberg version in that case, easier later to sync > > > 2. TestHiveIcebergCRUD.java – testReadAndWriteFormatV2Partitioned_PosDelete_**RowSupplied**, testReadAndWriteFormatV2Partitioned_PosDelete_**RowNotSupplied** are using row() and as test name suggest it is testing that functionality. I'll remove these test ? > > could you please test if we would be able to consume legacy v2 with row data. do not need tests for write PosDelete_**RowSupplied** I've replaced the older UT with a new UT `testConsumeLegacyFormatV2Partitioned_PosDelete_RowSupplied` , It makes use of `FileHelpers.testOnlyPosDeleteFileWithRow` (a test class from upstream iceberg, which pre-exist in hive) to generate positional deletes with rows -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
