ayushtkn commented on code in PR #6872:
URL: https://github.com/apache/hive/pull/6872#discussion_r4274541772
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java:
##########
@@ -171,13 +171,27 @@ public class HiveIcebergMetaHook extends
BaseHiveIcebergMetaHook {
private AlterTableType currentAlterTableOp;
private HiveLock commitLock;
private List<SQLDefaultConstraint> sqlDefaultConstraints;
+ private boolean commitPhaseStarted;
public HiveIcebergMetaHook(Configuration conf) {
super(conf);
}
+ @Override
+ public void rollbackCreateTable(org.apache.hadoop.hive.metastore.api.Table
hmsTable) {
+ if (commitPhaseStarted && tableProperties != null) {
Review Comment:
I think `HiveIcebergMetaHook` itself has a gaurd for `HiveCatalog`
https://github.com/apache/hive/blob/b10b11a0363f764486af7b2c7408771b2b456cd0/iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java#L265-L267
that should do the trick imo, beyond that would be overkill
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
