dengzhhu653 commented on code in PR #6887:
URL: https://github.com/apache/hive/pull/6887#discussion_r4332976830
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/tools/metatool/MetaToolTaskDedupColumns.java:
##########
@@ -69,10 +70,10 @@ void execute() {
daemon.setDaemon(true);
daemon.start();
}
- result = getObjectStore().dedupColumns(catalogFilter, dbFilter,
tableFilter, progress, isDryRun, isVerbose);
- } catch (MetaException ex) {
- // Deadline.startTimer throws MetaException, this shouldn't happen as
the Deadline has been registered.
- System.err.println(ex.getMessage());
+ result = getObjectStore().dedupColumns(catalogFilter, dbFilter,
tableFilter, progress, isDryRun, isVerbose,
+ getCl().isClearMarker());
+ } catch (Throwable ex) {
+ ex.printStackTrace(System.err);
Review Comment:
Without rethrowing the exception helps the task print the task summary at
the end, and the exception will be propagated to HiveMetaTool in case of task
failure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
