dengzhhu653 commented on code in PR #6887:
URL: https://github.com/apache/hive/pull/6887#discussion_r4450662287
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/tools/metatool/MetaToolTaskDedupColumns.java:
##########
@@ -89,9 +90,16 @@ void execute() {
if (result != null) {
printSummary(result, isDryRun, isVerbose);
if (result.getException() != null) {
- if (result.getException().getCause() instanceof DeadlineException
deadline) {
- // Just print the timeout message
- System.err.println(deadline.getMessage());
+ DeadlineException deadline = findDeadlineCause(result.getException());
+ if (deadline != null) {
+ long timeoutSeconds = Math.max(1, timeoutMs / 1000);
+ System.err.println("HiveMetaTool -dedupColumns timed out after " +
timeoutSeconds
+ + " second(s). The configured limit is -timeout <seconds> or "
+ + MetastoreConf.ConfVars.DEDUP_COLUMNS_TIMEOUT.getVarname() + "
(default in minutes).");
+ System.err.println("Increase the limit with -timeout <seconds> or
set "
+ + MetastoreConf.ConfVars.DEDUP_COLUMNS_TIMEOUT.getVarname()
+ + " to a larger value (minutes), then re-run. Tables already
processed can be skipped if marked "
+ + "with " + ColumnDeduplicator.COLUMN_DEDUPLICATOR_MARKER + ".");
return;
Review Comment:
It's intended, as the tool haven't done anything wrong, and can perform
again with a clean retry, the previous scanned tables can be skipped.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
