dengzhhu653 commented on code in PR #6884:
URL: https://github.com/apache/hive/pull/6884#discussion_r4407563760
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/handler/TransactionHandler.java:
##########
@@ -491,6 +501,15 @@ public void compact(CompactionRequest rqst) throws
TException {
}
@Override
public CompactionResponse compact2(CompactionRequest rqst) throws TException
{
+ // compact2 is a maintenance API: trusted callers (HiveServer2, the
compactor) have already been authorized
+ // for the operation, everybody else is authorized against the requested
table.
+ if (!hasProxyPrivilege()) {
+ try {
+ authorizeAndPrepareCompactionRequest(rqst);
+ } catch (Exception e) {
+ rethrowException(e);
Review Comment:
we don't need to re-throw the exception
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
