DanielZhu58 commented on code in PR #6884:
URL: https://github.com/apache/hive/pull/6884#discussion_r4407038903
##########
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestFilterHooks.java:
##########
@@ -293,18 +293,26 @@ protected void creatEnv(Configuration conf) throws
Exception {
TestTxnDbUtil.cleanDb(conf);
TestTxnDbUtil.prepDb(conf);
- CompactionRequest tbl1CompactionRequest = new CompactionRequest();
- tbl1CompactionRequest.setDbname(DBNAME1);
- tbl1CompactionRequest.setTablename(TAB1);
- tbl1CompactionRequest.setType(CompactionType.MAJOR);
- client.compact2(tbl1CompactionRequest);
-
- CompactionRequest tbl2CompactionRequest = new CompactionRequest();
- tbl2CompactionRequest.setDbname(DBNAME1);
- tbl2CompactionRequest.setTablename(TAB2);
- tbl2CompactionRequest.setType(CompactionType.MINOR);
- tbl2CompactionRequest.setPartitionname("name=value1");
- client.compact2(tbl2CompactionRequest);
+ // Enqueue compactions while the filter hook is not blocking table names
(server-side
+ // authorization on compact2 rejects blocked tables).
+ boolean origBlockResults = DummyMetaStoreFilterHookImpl.blockResults;
+ DummyMetaStoreFilterHookImpl.blockResults = false;
+ try {
+ CompactionRequest tbl1CompactionRequest = new CompactionRequest();
+ tbl1CompactionRequest.setDbname(DBNAME1);
+ tbl1CompactionRequest.setTablename(TAB1);
+ tbl1CompactionRequest.setType(CompactionType.MAJOR);
+ client.compact2(tbl1CompactionRequest);
+
+ CompactionRequest tbl2CompactionRequest = new CompactionRequest();
+ tbl2CompactionRequest.setDbname(DBNAME1);
+ tbl2CompactionRequest.setTablename(TAB2);
+ tbl2CompactionRequest.setType(CompactionType.MINOR);
+ tbl2CompactionRequest.setPartitionname("name=value1");
+ client.compact2(tbl2CompactionRequest);
+ } finally {
+ DummyMetaStoreFilterHookImpl.blockResults = origBlockResults;
+ }
Review Comment:
That change to TestFilterHooks is reverted, so it no longer touches
blockResults.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
