difin commented on code in PR #6930: URL: https://github.com/apache/hive/pull/6930#discussion_r4428859631
########## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java: ########## Review Comment: RENAME gets a NoLock here and sends no CAS on metadata_location. The write itself happens in `commitAlterTable` → `Catalogs.renameTable` → `HiveCatalog.renameTableOrView`, which reads the HMS table (line 424) and writes it back under the new name (line 431). It uses neither a lock nor a CAS. A commit that lands between the two is reverted, because the rename writes back the metadata_location it read. That's the same lost update this PR fixes for the other alters. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
