deniskuzZ commented on code in PR #6930: URL: https://github.com/apache/hive/pull/6930#discussion_r4444875171
########## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java: ########## Review Comment: It predates this PR, and upstream Iceberg's `HiveCatalog` has the same code. RENAME isn't an Iceberg commit: the hook hands it to `HiveCatalog.renameTableOrView`, which reads the table and writes it back outside `doCommit`'s lock or CAS. I've filed HIVE-30234 for it and left it out of this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
