deniskuzZ commented on code in PR #6837:
URL: https://github.com/apache/hive/pull/6837#discussion_r4443617407


##########
packaging/src/docker/Dockerfile:
##########
@@ -125,6 +125,30 @@ RUN set -eux; \
     fi; \
     rm -rf /opt/tez-snapshot-download
 
+# Hadoop 3.4.3 puts hadoop-aws on the default classpath but no longer ships 
the AWS SDK v2 bundle it links against,
+# so s3a:// needs it from here. It goes next to hadoop-aws in 
share/hadoop/common/lib, which every process reads
+# through the Hadoop classpath, the hadoop CLI included. An empty 
AWS_SDK_VERSION leaves it out. So does a Hadoop
+# release that ships its own bundle (up to 3.4.2): a second one would end up 
on the LLAP daemon classpath, which reads
+# share/hadoop/tools/lib. build.sh stages a cached copy under aws-jars/ in the 
build context; otherwise the bundle is
+# downloaded.
+ARG AWS_SDK_VERSION=
+ARG AWS_SDK_REPO_URL=https://repo1.maven.org/maven2
+RUN --mount=type=bind,target=/build-context \
+    set -eux; \
+    bundle="bundle-${AWS_SDK_VERSION}.jar"; \
+    lib_dir="${HADOOP_HOME}/share/hadoop/common/lib"; \

Review Comment:
   👍 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to