deniskuzZ commented on PR #6837:
URL: https://github.com/apache/hive/pull/6837#issuecomment-6580413940
Nit, can be a follow-up:
with 3.4.3, `hadoop-aws` sits in `share/hadoop/common/lib`, always on the
classpath, so `HADOOP_OPTIONAL_TOOLS=hadoop-aws` has nothing left to add. It is
still set in `packaging/src/kubernetes/README.md` (S3/Ozone examples and the
`cluster.storage.envVars` description),
`itests/test-docker/k8s/{hive,hive-metastore}/deployment.yaml` and
`packaging/src/docker/start-hive.sh --ozone`, where it reads as required. Worth
dropping it there.
`start-hive.sh` needs it today only because the docker README's examples
still build `-hadoop 3.4.1` (Ozone, and LLAP), where `hadoop-aws` is in
`tools/lib`.
Could you move those examples to 3.4.3 too (`-hadoop 3.4.3`, or drop
`-hadoop` so `build.sh` takes `hadoop.version` from the pom)? Then the variable
can go from `start-hive.sh` as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
