zabetak commented on code in PR #6953:
URL: https://github.com/apache/hive/pull/6953#discussion_r4537421760
##########
Jenkinsfile:
##########
@@ -31,9 +31,13 @@ properties([
parameters([
string(name: 'SPLIT', defaultValue: '22', description: 'Number of
buckets to split tests into.'),
string(name: 'OPTS', defaultValue: '', description: 'additional maven
opts'),
+ string(name: 'IMAGE', defaultValue: '', description: 'precommit image
to use instead of the default one (e.g. a candidate built from
dev-support/docker/precommit)'),
])
])
+// Built from dev-support/docker/precommit/Dockerfile and pushed by
.github/workflows/precommit-image.yml.
+this.precommitImage = 'apache/hive:precommit'
Review Comment:
I wouldn't use `apache/hive:precommit` to avoid confusing end-users that are
mainly interested to use the product. There is also a risk of ASF legal/infra
bothering us if we mix those.
Maybe `apache/hive-ci-runner:...` or basically anything with
`apache/hive-ci-xxx` prefix is fine with me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
