abstractdog commented on code in PR #6953:
URL: https://github.com/apache/hive/pull/6953#discussion_r4551175095
##########
dev-support/docker/precommit/README.md:
##########
@@ -0,0 +1,199 @@
+<!--
+{% comment %}
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements. See the NOTICE file distributed with
+this work for additional information regarding copyright ownership.
+The ASF licenses this file to you under the Apache License, Version 2.0
+(the "License"); you may not use this file except in compliance with
+the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+{% endcomment %}
+-->
+# Hive precommit image
+
+The [Jenkinsfile](../../../Jenkinsfile) runs every precommit stage in this
image, with a
+`docker:dind` sidecar for the tests that start databases in containers.
+
+The image is kept small on purpose. It holds:
+
+* Debian (slim), with the GNU shell tools that scripts and tests expect. It is
glibc based on
+ purpose: tests run prebuilt native code that is linked against glibc, such
as the Kudu
+ mini cluster.
+* a JDK (Eclipse Temurin), without jmods and man pages
+* Maven
+* the client part of Hadoop, used only by `bin/schematool` in the `init@<db>`
stages
+ (see [precommit-init-metastore.sh](../../precommit-init-metastore.sh))
+* the docker CLI, git, openssl, python3, rsync, tini and xmlstarlet
+
+Everything else (Tez, the JDBC drivers, the Hive build dependencies) is
fetched by Maven
+during the build. Before adding a package, check whether Maven can provide it
instead.
+
+## How the image is published
+
+The [precommit-image](../../../.github/workflows/precommit-image.yml) workflow
builds the
+image and smoke tests it on every pull request that changes this directory.
When such a
+change lands on master, the workflow publishes the image for `linux/amd64` and
`linux/arm64`
+as `apache/hive:precommit`. That tag is the `precommitImage` of the
Jenkinsfile, and
+the precommit job pulls it again on every run. The tag is overwritten on every
publish:
+once the change is merged, every precommit run, on every branch, uses the new
image.
+
+## Changing the image, step by step
Review Comment:
yeah, modifying accordingly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
