busbey commented on a change in pull request #86: YETUS-934. Precommit does not accept a caller's value of MAVEN_ARGS URL: https://github.com/apache/yetus/pull/86#discussion_r376144102
########## File path: precommit/src/main/shell/test-patch.d/maven.sh ########## @@ -14,7 +14,9 @@ # See the License for the specific language governing permissions and # limitations under the License. -declare -a MAVEN_ARGS +# Accept a value of MAVEN_ARGS from the calling context +# shellcheck disable=SC2206 Review comment: > @busbey you saying we have the order of operations wrong? Personality appends to the base plugin? Yes. The docs say `personality_globals` is done after importing plugins. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
