aw-was-here commented on issue #86: YETUS-934. Precommit does not accept a caller's value of MAVEN_ARGS URL: https://github.com/apache/yetus/pull/86#issuecomment-583480369 Never mind. I forgot that MAVEN_OPTS is for JVM options. Haha. Since the goal here is to set options for surefire, then why not just add these to the chain in the unit control in the personality like the other maven command line options in the hbase personality? ```bash if [[ ${testtype} = unit ]]; then extra="${extra} -PrunAllTests" # Inject the jenkins build-id for our surefire invocations # Used by zombie detection stuff, even though we're not including that yet. if [ -n "${BUILD_ID}" ]; then extra="${extra} -Dbuild.id=${BUILD_ID}" fi fi ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
