neilconway commented on code in PR #22516: URL: https://github.com/apache/datafusion/pull/22516#discussion_r3314875731
########## datafusion/functions/src/macros.rs: ########## Review Comment: Personally I'd prefer to be explicit, rather than depending on the coupling / timing dependency between type coercion and `return_type`. There's enough subtle behavior in this code as it is... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
