kosiew commented on code in PR #22609: URL: https://github.com/apache/datafusion/pull/22609#discussion_r3332911607
########## docs/source/library-user-guide/query-optimizer.md: ########## @@ -42,7 +42,7 @@ For a deeper background on optimizer architecture and rule types and predicates, [part 2]: https://datafusion.apache.org/blog/2025/06/15/optimizing-sql-dataframes-part-two [using ordering for better plans in apache datafusion]: https://datafusion.apache.org/blog/2025/03/11/ordering-analysis [dynamic filters: passing information between operators during execution for 25x faster queries]: https://datafusion.apache.org/blog/2025/09/10/dynamic-filters -[optimizer rule reference]: https://docs.rs/datafusion/latest/datafusion/index.html#built-in-optimizer-rules +[optimizer rule reference]: https://docs.rs/datafusion-optimizer/latest/datafusion_optimizer/optimizer/trait.OptimizerRule.html Review Comment: I think this link change introduces a mismatch with what the surrounding paragraph promises. The text describes a reference list for built-in analyzer, logical optimizer, and physical optimizer rules, but the new target only points to the `datafusion_optimizer::optimizer::OptimizerRule` trait documentation. That page is useful for logical optimizer rule implementors, but it does not cover `AnalyzerRule`s or `PhysicalOptimizerRule`s. As a result, readers following this link may not find the information they're expecting. Could we either link to documentation that covers all three rule categories, or adjust the wording and provide separate links for analyzer, logical optimizer, and physical optimizer rules? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
