viirya commented on code in PR #27111: URL: https://github.com/apache/datafusion/pull/27111#discussion_r4483904928
########## datafusion/optimizer/src/decorrelate_predicate_subquery.rs: ########## Review Comment: Good catch, fixed. Decorrelation now sets the count only on a null-aware join, so any other join keeps `None`, the same as `Join::try_new` and the builder. `decorrelated_mark_join_sets_value_keys_only_when_null_aware` (core `sql/joins.rs`) checks that scalar and multi-column `IN` mark joins on non-nullable keys carry `None`, and that their null-aware counterparts carry `Some(1)` and `Some(2)`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
