viirya commented on PR #27111: URL: https://github.com/apache/datafusion/pull/27111#issuecomment-6671832932
@kumarUjjawal following alamb's review I dropped `NonZeroUsize` and the proto field changes, so the count is a `usize` again, with `0` as unset. With that, the `Option` setters and the shared `non_zero_usize_from_wire` helper from my earlier replies are gone. The other fixes from your review (the check order, the empty `on` check, decorrelation setting the count only on a null-aware join, the smaller test helper and the flattened block) are kept. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
