lakshaydevoo-arch commented on PR #26966: URL: https://github.com/apache/datafusion/pull/26966#issuecomment-6708991313
thanks for the review! i've updated the nullable path to process the validity bitmap in 64-row chunks, using a regular loop for fully valid chunks and bit scanning for the rest. also added tests for sliced dictionaries, null keys and values, shorter hash buffers, and 64-row boundaries. merged the latest upstream main changes as well. fmt, hash_utils tests, and clippy all pass locally. i've left the review threads open in case there's anything else to address -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
