lakshaydevoo-arch commented on code in PR #27008:
URL: https://github.com/apache/datafusion/pull/27008#discussion_r4502605851
##########
datafusion/common/benches/with_hashes.rs:
##########
@@ -242,6 +291,13 @@ pub fn make_rng() -> StdRng {
StdRng::seed_from_u64(42)
}
+/// RNG for null masks. Deliberately not `make_rng()`: sharing its stream makes
+/// null positions a function of the generated values (e.g. which pool string
+/// was picked for a row).
+fn make_null_rng() -> StdRng {
+ StdRng::seed_from_u64(43)
Review Comment:
i've restored seed 42 for the existing 3% cases and checked the generated
inputs against upstream main. all 29 existing cases match, including the null
masks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
