lakshaydevoo-arch commented on code in PR #27008:
URL: https://github.com/apache/datafusion/pull/27008#discussion_r4502610486
##########
datafusion/common/benches/with_hashes.rs:
##########
@@ -159,6 +180,26 @@ fn criterion_benchmark(c: &mut Criterion) {
];
do_hash_test(b, &arrays);
});
+ for &null_percent in additional_null_densities {
Review Comment:
fixed this by using one helper to register the single and multiple cases for
both the existing benchmarks and the additional densities. the existing
benchmark names are unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
