ngli-me commented on code in PR #12481:
URL: https://github.com/apache/datafusion/pull/12481#discussion_r1767607106
##########
datafusion/expr/src/logical_plan/ddl.rs:
##########
@@ -284,6 +346,15 @@ pub struct CreateCatalogSchema {
pub schema: DFSchemaRef,
}
+impl PartialOrd for CreateCatalogSchema {
+ fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
+ match self.schema_name.partial_cmp(&other.schema_name) {
Review Comment:
I like this, I'll make some changes for the bigger manual implementations to
follow this format to begin with!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
