ngli-me commented on code in PR #12481:
URL: https://github.com/apache/datafusion/pull/12481#discussion_r1767604101
##########
datafusion/expr/src/logical_plan/ddl.rs:
##########
@@ -232,8 +232,61 @@ impl Hash for CreateExternalTable {
}
}
+impl PartialOrd for CreateExternalTable {
Review Comment:
Yeah, I'm not super happy with the way the syntax on this turned out, but
the first field, `schema` prevents us from deriving it. I was looking at some
alternatives, but it looks like Rust doesn't have a way to ignore a field for a
derived trait by default. One option is to use something like the
[derivative](https://crates.io/crates/derivative) crate, but that means another
attribute for the struct, and additional attributes for the field.
In general, `DFSchemaRef` and `Schema` are the main blockers for deriving
PartialOrd for structs, with the other cases (also) having HashMaps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
