liamzwbao commented on code in PR #16686:
URL: https://github.com/apache/datafusion/pull/16686#discussion_r2188415579
##########
datafusion/datasource/src/source.rs:
##########
@@ -325,6 +328,9 @@ impl ExecutionPlan for DataSourceExec {
new_node.data_source = data_source;
new_node.cache =
Self::compute_properties(Arc::clone(&new_node.data_source));
+ // Add the missing filters' equivalence info when filters
pushdown is applied
+ let filter = conjunction(res.filters.collect_supported());
+ new_node = new_node.add_filter_equivalence_info(filter)?;
Review Comment:
I think this will add the eq info from filter pushdown into the existing eq
info group from `DataSource`.
Maybe it's better if we have a test case for it, but I'm not sure how to
create a `DataSource` with eq info here. Are there any examples we can refer to?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
