alamb commented on code in PR #16686:
URL: https://github.com/apache/datafusion/pull/16686#discussion_r2193493034
##########
datafusion/core/tests/physical_optimizer/filter_pushdown/mod.rs:
##########
@@ -289,7 +289,7 @@ fn test_no_pushdown_through_aggregates() {
Ok:
- FilterExec: b@1 = bar
- CoalesceBatchesExec: target_batch_size=100
- - AggregateExec: mode=Final, gby=[a@0 as a, b@1 as b], aggr=[cnt]
+ - AggregateExec: mode=Final, gby=[a@0 as a, b@1 as b],
aggr=[cnt], ordering_mode=PartiallySorted([0])
Review Comment:
I agree -- this looks good to me (the filter pushdown now lets the gby know
that the data is sorted on `a` which makes sense as `a` now has exactly one
value (`foo`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
