alamb opened a new issue, #17260: URL: https://github.com/apache/datafusion/issues/17260
### Is your feature request related to a problem or challenge? While reviewing https://github.com/apache/datafusion/pull/17197 with @adriangb @jonathanc-n @kosiew and @nuno-faria I noticed that `hash_join.rs` is currently huge (over 5k lines long) https://github.com/apache/datafusion/blob/main/datafusion/physical-plan/src/joins/hash_join.rs As we add more sophistication to this area in DataFusion I think having it split into smaller modules would help make it easier to understand ### Describe the solution you'd like Split `hash_join.rs` into smaller modules ### Describe alternatives you've considered I recommend the standard structure like * datafusion/physical-plan/src/joins/hash_join/mod.rs * datafusion/physical-plan/src/joins/hash_join/exec.rs (HashJoinExec) * datafusion/physical-plan/src/joins/hash_join/stream.rs * datafusion/physical-plan/src/joins/hash_join/shared_bounds.rs * etc ### Additional context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
