comphead commented on code in PR #2327:
URL: https://github.com/apache/datafusion-comet/pull/2327#discussion_r2330746423
##########
docs/source/user-guide/latest/operators.md:
##########
@@ -22,16 +22,24 @@
The following Spark operators are currently replaced with native versions.
Query stages that contain any operators
not supported by Comet will fall back to regular Spark execution.
-| Operator | Notes |
-| --------------------- | ----- |
-| Projection | |
-| Filter | |
-| Sort | |
-| Hash Aggregate | |
-| Limit | |
-| Sort-merge Join | |
-| Hash Join | |
-| BroadcastHashJoinExec | |
-| Shuffle | |
-| Expand | |
-| Union | |
+| Operator | Spark-Compatible? | Compatibility Notes
|
+| ----------------------- | ----------------- |
------------------------------------------------------------------------------------------------------------------
|
+| BatchScanExec | Yes | Supports Parquet files and
Apache Iceberg Parquet scans. See the [Comet Compatibility Guide] for more
information. |
+| BroadcastExchangeExec | Yes |
|
+| BroadcastHashJoinExec | Yes |
|
+| ExpandExec | Yes |
|
+| FileSourceScanExec | Yes | Supports Parquet files. See
the [Comet Compatibility Guide] for more information.
|
+| FilterExec | Yes |
|
+| GlobalLimitExec | Yes |
|
+| HashAggregateExec | Yes |
|
+| LocalLimitExec | Yes |
|
+| ObjectHashAggregateExec | Yes | Limited support
|
Review Comment:
Just investigated real quick the
```
case aggregate: BaseAggregateExec
if (aggregate.isInstanceOf[HashAggregateExec] ||
aggregate.isInstanceOf[ObjectHashAggregateExec]) &&
CometConf.COMET_EXEC_AGGREGATE_ENABLED.get(conf) =>
```
implementation I can't see any mention of Limited support?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
