andygrove commented on code in PR #2286:
URL: https://github.com/apache/datafusion-comet/pull/2286#discussion_r2353571004
##########
native/spark-expr/src/comet_scalar_funcs.rs:
##########
@@ -192,6 +192,24 @@ struct CometScalarFunction {
func: ScalarFunctionImplementation,
}
+impl PartialEq for CometScalarFunction {
+ fn eq(&self, other: &Self) -> bool {
+ self.name == other.name
+ && self.signature == other.signature
+ && self.data_type == other.data_type
Review Comment:
if we do not depend on the behavior, and we do not have tests, perhaps it is
better to have them call `unimplemented!()` instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
